Skip to content

bluetooth: samples: Add sample showing basic channel sounding features #79499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 1 commit into from
Nov 16, 2024
Merged

bluetooth: samples: Add sample showing basic channel sounding features #79499

nashif merged 1 commit into from
Nov 16, 2024

Conversation

@olivier-le-sage
Copy link
Contributor

@olivier-le-sage olivier-le-sage commented Oct 7, 2024 •
edited by kartben
Loading

@olivier-le-sage olivier-le-sage force-pushed the cs-test-sample branch 19 times, most recently from ce83e81 to e2cf12c Compare October 9, 2024 13:27
olivier-le-sage
olivier-le-sage commented Oct 14, 2024
View reviewed changes
olivier-le-sage
olivier-le-sage commented Oct 14, 2024
View reviewed changes
@olivier-le-sage olivier-le-sage force-pushed the cs-test-sample branch 6 times, most recently from 2dbd244 to 2b891b4 Compare October 18, 2024 12:41
ivaniushkov
ivaniushkov reviewed Oct 25, 2024
View reviewed changes
samples/bluetooth/channel_sounding/src/distance_estimation.c Outdated
Copy link
Member

@ivaniushkov ivaniushkov Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use qsort() from standard library to avoid O(n^2) complexity?
Not sure how much time we actually spend sorting but I think it can improve performance a bit

@Thalley Thalley removed their request for review October 25, 2024 14:03
rugeGerritsen
rugeGerritsen reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@rugeGerritsen rugeGerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample code looks really nice and structured. Added some ideas on how to improve the documentation.

I need to get a second 54L DK so that I can start running it :)

@eriksandgren eriksandgren mentioned this pull request Oct 29, 2024
Draft
sean-madigan
sean-madigan reviewed Oct 30, 2024
View reviewed changes
samples/bluetooth/channel_sounding/src/distance_estimation.c Outdated
Copy link
Contributor

@sean-madigan sean-madigan Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BT_HCI_LE_CS_TIME_DIFFERENCE_NOT_AVAILABLE is out of the range of int16_t tod_toa_reflector

Copy link
Contributor Author

@olivier-le-sage olivier-le-sage Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it back to uint16_t in hci_types.h (separate PR)

@olivier-le-sage olivier-le-sage force-pushed the cs-test-sample branch 3 times, most recently from 85e0279 to 3a3b765 Compare October 31, 2024 14:18
@olivier-le-sage
Copy link
Contributor Author

olivier-le-sage commented Oct 31, 2024

Refactored a bit to remove the console kconfigs/interaction, based on feedback about best practice. Now initiator and reflector are in separate folders/apps and the sample runs itself automatically on boot.

theob-pro
theob-pro reviewed Nov 1, 2024
View reviewed changes
@olivier-le-sage olivier-le-sage force-pushed the cs-test-sample branch 2 times, most recently from 44b06dc to 68e2664 Compare November 1, 2024 09:05
jhedberg
jhedberg requested changes Nov 1, 2024
View reviewed changes
kartben
kartben reviewed Nov 1, 2024
View reviewed changes
@olivier-le-sage olivier-le-sage force-pushed the cs-test-sample branch 2 times, most recently from a30074f to 2f94918 Compare November 1, 2024 10:39
@olivier-le-sage
bluetooth: samples: Add samples showing basic channel sounding features
97b62b2 
These samples demonstrate how to use the bluetooth 6.0 channel
sounding APIs. A basic distance estimation algorithm is included.

Signed-off-by: Olivier Lesage <[email protected]>
@mmahadevan108 mmahadevan108 added this to the v4.1.0 milestone Nov 1, 2024
@nashif nashif merged commit fc8d942 into zephyrproject-rtos:main Nov 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben left review comments

@rugeGerritsen rugeGerritsen rugeGerritsen left review comments

@jhedberg jhedberg jhedberg approved these changes

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@hermabe hermabe Awaiting requested review from hermabe

@nashif nashif Awaiting requested review from nashif

@sjanc sjanc Awaiting requested review from sjanc

+4 more reviewers

@eriksandgren eriksandgren eriksandgren left review comments

@sean-madigan sean-madigan sean-madigan left review comments

@ivaniushkov ivaniushkov ivaniushkov left review comments

@theob-pro theob-pro theob-pro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhedberg jhedberg

@alwa-nordic alwa-nordic

Labels

area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Samples Samples

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.